Mercurial > sdl-ios-xcode
annotate sdl-config.in @ 4324:1496aa09e41e SDL-1.2
Steven Noonan to sdl
While trying to build the SDLMain.m included with SDL 1.2.14, with
#define SDL_USE_NIB_FILE 1:
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:
In function '-[SDLMain fixMenu:withAppName:]':
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:122:
warning: 'sizeToFit' is deprecated (declared at
/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSMenu.h:281)
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:
In function 'main':
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:376:
warning: 'poseAsClass:' is deprecated (declared at
/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSObject.h:127)
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:376:
error: 'poseAsClass:' is unavailable (declared at
/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSObject.h:127)
/Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:377:
warning: passing argument 2 of 'NSApplicationMain' from incompatible
pointer type
Eric Wing to Sam
I don't have time today to look at this in detail, but the problem is definitely the poseAsClass: method.
This was deprecated in Obj-C 2.0 and not retained in 64-bit.
I've never used this method and it has always been limited to esoteric uses. I think this is why Apple wanted to dump it (among complicating some other things they do). I have read about others getting bit by this when migrating. Long story short, there really isn't a migration path for this method. The question that then must be asked is why are we using it (what does it accomplish), and then figure out the 'proper' way of accomplishing that.
Glancing at SDLMain.m, it's not obvious to me why it is there or what it is really accomplishing. My only speculation is that NSApplicationMain hardcodes something to look for NSApplication and a subclass (SDLApplication) fails for some reason (assuming that the original coder did this for good reason).
Three thoughts come to mind.
1) The Info.plist has properties to control things related to the startup class and nib.
NSPrincipalClass, NSMainNibFile
Maybe principle class needs to be SDLApplication and we can delete the poseAs
2) I was told that 10.6 introduced new APIs to make programatic NIB wrangling and avoidance easier. Unfortunately, I don't know the specifics.
3) Instead of subclassing NSApplication in SDLMain.m, maybe we can just add a category. It looks like the following is the only thing that is done (quick glance):
@interface SDLApplication : NSApplication
@end
@implementation SDLApplication
/* Invoked from the Quit menu item */
- (void)terminate:(id)sender
{
/* Post a SDL_QUIT event */
SDL_Event event;
event.type = SDL_QUIT;
SDL_PushEvent(&event);
}
@end
So instead, we change this to: (warning written in mail and untested)
@interface NSApplication (SDLApplication)
- (void) terminate:(id)sender;
@end
@implementation NSApplication (SDLApplication)
/* Invoked from the Quit menu item */
- (void)terminate:(id)sender
{
/* Post a SDL_QUIT event */
SDL_Event event;
event.type = SDL_QUIT;
SDL_PushEvent(&event);
}
@end
Then everywhere SDLApplication is used, we change it to NSApplication (and remove the poseAsClass line).
Perhaps you could ask the bug reporter to try this solution (#3).
And if that fails, maybe try #1.
-Eric
Steven Noonan to Sam
The suggested change (diff below) seems to work fine.
- Steven
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Mon, 12 Oct 2009 21:07:12 +0000 |
parents | 56ec4d962487 |
children |
rev | line source |
---|---|
0 | 1 #!/bin/sh |
2 | |
3 prefix=@prefix@ | |
4 exec_prefix=@exec_prefix@ | |
5 exec_prefix_set=no | |
3929
56ec4d962487
Date: Sat, 31 Mar 2007 16:39:52 +0200
Ryan C. Gordon <icculus@icculus.org>
parents:
1856
diff
changeset
|
6 libdir=@libdir@ |
0 | 7 |
1647
2af911d41a08
Date: Thu, 20 Apr 2006 10:13:34 +0200
Sam Lantinga <slouken@libsdl.org>
parents:
1548
diff
changeset
|
8 @ENABLE_STATIC_FALSE@usage="\ |
2af911d41a08
Date: Thu, 20 Apr 2006 10:13:34 +0200
Sam Lantinga <slouken@libsdl.org>
parents:
1548
diff
changeset
|
9 @ENABLE_STATIC_FALSE@Usage: sdl-config [--prefix[=DIR]] [--exec-prefix[=DIR]] [--version] [--cflags] [--libs]" |
2af911d41a08
Date: Thu, 20 Apr 2006 10:13:34 +0200
Sam Lantinga <slouken@libsdl.org>
parents:
1548
diff
changeset
|
10 @ENABLE_STATIC_TRUE@usage="\ |
2af911d41a08
Date: Thu, 20 Apr 2006 10:13:34 +0200
Sam Lantinga <slouken@libsdl.org>
parents:
1548
diff
changeset
|
11 @ENABLE_STATIC_TRUE@Usage: sdl-config [--prefix[=DIR]] [--exec-prefix[=DIR]] [--version] [--cflags] [--libs] [--static-libs]" |
0 | 12 |
13 if test $# -eq 0; then | |
14 echo "${usage}" 1>&2 | |
15 exit 1 | |
16 fi | |
17 | |
18 while test $# -gt 0; do | |
19 case "$1" in | |
1856
21f13c787b46
Date: Mon, 22 May 2006 01:16:47 -0400
Sam Lantinga <slouken@libsdl.org>
parents:
1647
diff
changeset
|
20 -*=*) optarg=`echo "$1" | LC_ALL="C" sed 's/[-_a-zA-Z0-9]*=//'` ;; |
0 | 21 *) optarg= ;; |
22 esac | |
23 | |
24 case $1 in | |
25 --prefix=*) | |
26 prefix=$optarg | |
27 if test $exec_prefix_set = no ; then | |
28 exec_prefix=$optarg | |
29 fi | |
30 ;; | |
31 --prefix) | |
32 echo $prefix | |
33 ;; | |
34 --exec-prefix=*) | |
35 exec_prefix=$optarg | |
36 exec_prefix_set=yes | |
37 ;; | |
38 --exec-prefix) | |
39 echo $exec_prefix | |
40 ;; | |
41 --version) | |
42 echo @SDL_VERSION@ | |
43 ;; | |
44 --cflags) | |
490
7e53d17ec798
The portable way of including SDL is #include "SDL.h"
Sam Lantinga <slouken@libsdl.org>
parents:
296
diff
changeset
|
45 echo -I@includedir@/SDL @SDL_CFLAGS@ |
0 | 46 ;; |
47 @ENABLE_SHARED_TRUE@ --libs) | |
1548
a77c022733fe
EXTRA_LDFLAGS are the linker flags and libraries needed to build SDL.
Sam Lantinga <slouken@libsdl.org>
parents:
1361
diff
changeset
|
48 @ENABLE_SHARED_TRUE@ echo -L@libdir@ @SDL_RLD_FLAGS@ @SDL_LIBS@ |
0 | 49 @ENABLE_SHARED_TRUE@ ;; |
50 @ENABLE_STATIC_TRUE@@ENABLE_SHARED_TRUE@ --static-libs) | |
51 @ENABLE_STATIC_TRUE@@ENABLE_SHARED_FALSE@ --libs|--static-libs) | |
1548
a77c022733fe
EXTRA_LDFLAGS are the linker flags and libraries needed to build SDL.
Sam Lantinga <slouken@libsdl.org>
parents:
1361
diff
changeset
|
52 @ENABLE_STATIC_TRUE@ echo -L@libdir@ @SDL_RLD_FLAGS@ @SDL_STATIC_LIBS@ |
0 | 53 @ENABLE_STATIC_TRUE@ ;; |
54 *) | |
55 echo "${usage}" 1>&2 | |
56 exit 1 | |
57 ;; | |
58 esac | |
59 shift | |
60 done |