annotate BUGS @ 4324:1496aa09e41e SDL-1.2

Steven Noonan to sdl While trying to build the SDLMain.m included with SDL 1.2.14, with #define SDL_USE_NIB_FILE 1: /Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m: In function '-[SDLMain fixMenu:withAppName:]': /Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:122: warning: 'sizeToFit' is deprecated (declared at /Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSMenu.h:281) /Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m: In function 'main': /Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:376: warning: 'poseAsClass:' is deprecated (declared at /Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSObject.h:127) /Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:376: error: 'poseAsClass:' is unavailable (declared at /Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSObject.h:127) /Users/steven/Development/darwinia/targets/macosx/Darwinia/SDLMain.m:377: warning: passing argument 2 of 'NSApplicationMain' from incompatible pointer type Eric Wing to Sam I don't have time today to look at this in detail, but the problem is definitely the poseAsClass: method. This was deprecated in Obj-C 2.0 and not retained in 64-bit. I've never used this method and it has always been limited to esoteric uses. I think this is why Apple wanted to dump it (among complicating some other things they do). I have read about others getting bit by this when migrating. Long story short, there really isn't a migration path for this method. The question that then must be asked is why are we using it (what does it accomplish), and then figure out the 'proper' way of accomplishing that. Glancing at SDLMain.m, it's not obvious to me why it is there or what it is really accomplishing. My only speculation is that NSApplicationMain hardcodes something to look for NSApplication and a subclass (SDLApplication) fails for some reason (assuming that the original coder did this for good reason). Three thoughts come to mind. 1) The Info.plist has properties to control things related to the startup class and nib. NSPrincipalClass, NSMainNibFile Maybe principle class needs to be SDLApplication and we can delete the poseAs 2) I was told that 10.6 introduced new APIs to make programatic NIB wrangling and avoidance easier. Unfortunately, I don't know the specifics. 3) Instead of subclassing NSApplication in SDLMain.m, maybe we can just add a category. It looks like the following is the only thing that is done (quick glance): @interface SDLApplication : NSApplication @end @implementation SDLApplication /* Invoked from the Quit menu item */ - (void)terminate:(id)sender { /* Post a SDL_QUIT event */ SDL_Event event; event.type = SDL_QUIT; SDL_PushEvent(&event); } @end So instead, we change this to: (warning written in mail and untested) @interface NSApplication (SDLApplication) - (void) terminate:(id)sender; @end @implementation NSApplication (SDLApplication) /* Invoked from the Quit menu item */ - (void)terminate:(id)sender { /* Post a SDL_QUIT event */ SDL_Event event; event.type = SDL_QUIT; SDL_PushEvent(&event); } @end Then everywhere SDLApplication is used, we change it to NSApplication (and remove the poseAsClass line). Perhaps you could ask the bug reporter to try this solution (#3). And if that fails, maybe try #1. -Eric Steven Noonan to Sam The suggested change (diff below) seems to work fine. - Steven
author Sam Lantinga <slouken@libsdl.org>
date Mon, 12 Oct 2009 21:07:12 +0000
parents 89b0f3d12fe2
children
rev   line source
0
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
1
3915
89b0f3d12fe2 Removed the contents of the BUGS file, as most (all?) of the issues were
Ryan C. Gordon <icculus@icculus.org>
parents: 3888
diff changeset
2 Bugs are now managed in the SDL bug tracker, here:
0
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
3
3915
89b0f3d12fe2 Removed the contents of the BUGS file, as most (all?) of the issues were
Ryan C. Gordon <icculus@icculus.org>
parents: 3888
diff changeset
4 http://bugzilla.libsdl.org/
0
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
5
3915
89b0f3d12fe2 Removed the contents of the BUGS file, as most (all?) of the issues were
Ryan C. Gordon <icculus@icculus.org>
parents: 3888
diff changeset
6 You may report bugs there, and search to see if a given issue has already
89b0f3d12fe2 Removed the contents of the BUGS file, as most (all?) of the issues were
Ryan C. Gordon <icculus@icculus.org>
parents: 3888
diff changeset
7 been reported, discussed, and maybe even fixed.
0
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
8
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
9
27
a7e598a8d8be The keyboard modifiers are not set to the correct state on X11 startup.
Sam Lantinga <slouken@lokigames.com>
parents: 21
diff changeset
10
3915
89b0f3d12fe2 Removed the contents of the BUGS file, as most (all?) of the issues were
Ryan C. Gordon <icculus@icculus.org>
parents: 3888
diff changeset
11 You may also find help at the SDL mailing list. Subscription information:
0
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
12
3915
89b0f3d12fe2 Removed the contents of the BUGS file, as most (all?) of the issues were
Ryan C. Gordon <icculus@icculus.org>
parents: 3888
diff changeset
13 http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org
250
74a8f672f2f8 Added support for building SDL for EPOC/SymbianOS 6.0 (thanks Hannu!)
Sam Lantinga <slouken@libsdl.org>
parents: 172
diff changeset
14
3915
89b0f3d12fe2 Removed the contents of the BUGS file, as most (all?) of the issues were
Ryan C. Gordon <icculus@icculus.org>
parents: 3888
diff changeset
15 Bug reports are welcome here, but we really appreciate if you use Bugzilla, as
89b0f3d12fe2 Removed the contents of the BUGS file, as most (all?) of the issues were
Ryan C. Gordon <icculus@icculus.org>
parents: 3888
diff changeset
16 bugs discussed on the mailing list may be forgotten or missed.
0
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
17
27
a7e598a8d8be The keyboard modifiers are not set to the correct state on X11 startup.
Sam Lantinga <slouken@lokigames.com>
parents: 21
diff changeset
18