Mercurial > pylearn

changeset 1306:ef0f3deead94

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
coding_style: Updates about a few points discussed in today's meeting
author Olivier Delalleau <delallea@iro>
date Fri, 01 Oct 2010 15:27:26 -0400
parents b60a9b6eee68
children bc41fd23db25
files doc/v2_planning/coding_style.txt
diffstat 1 files changed, 10 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/doc/v2_planning/coding_style.txt	Fri Oct 01 15:27:03 2010 -0400
+++ b/doc/v2_planning/coding_style.txt	Fri Oct 01 15:27:26 2010 -0400
@@ -118,6 +118,9 @@
           is that we adopt the "import numpy as np" standard that's used in
           NumPy and SciPy itself. For NumPy heavy code this really cuts down
 	  on clutter, without significant impact on readability (IMHO).
+     OD: We discussed it during a meeting. We agreed not to use the 'np'
+         abbreviation at first. We may still revisit this point in the future
+         if we find situations where it would really help.
 
    * Imports should usually be on separate lines.
      OD: I would add an exception, saying it is ok to group multiple imports
@@ -381,6 +384,13 @@
 During committee's meeting, Fred mentioned a bug with Assembla links for
 multi-line commits.
 
+OD: About what I mentioned in a meeting:
+    - The size of the first line does not really matter (although keeping it
+      short is better, it is not truncated when you do 'hg log')
+    - The fetch commit message is like "Automated merge with
+      https://theanoclone.googlecode.com/hg/". It is too long to ask people to
+      use the same. I guess "Merge" would be the most logical message to use.
+      
 Tools to help us out
 ---------------------