Mercurial > pylearn

changeset 1263:10113a1050ce

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
More RST
author Pascal Lamblin <lamblinp@iro.umontreal.ca>
date Tue, 28 Sep 2010 16:27:21 -0400
parents 4d7fdd04b66a
children 34512d1d4e9c 879a5633bb52 0f69f303ba91
files doc/v2_planning/code_review.txt
diffstat 1 files changed, 37 insertions(+), 8 deletions(-) [+]
line wrap: on
line diff
--- a/doc/v2_planning/code_review.txt	Tue Sep 28 14:02:29 2010 -0400
+++ b/doc/v2_planning/code_review.txt	Tue Sep 28 16:27:21 2010 -0400
@@ -18,14 +18,43 @@
 Some system that we should check:
 ---------------------------------
 
-- `rietveld <http://code.google.com/p/rietveld/>` Made by Guido van Rossum, seam basic and svn only
-- `Gerrit <http://code.google.com/p/gerrit/>`, git only
-- *`Review Board <http://www.reviewboard.org>`_ 
-- *`Code Striker <http://codestriker.sourceforge.net/>`, hg added? David told in May 2009 it can do it easily.
-- *`Code Review plugins in Redmine <http://www.redmine.org/boards/3/topics/9627>`
-- `track PeerReviewPlugin <http://trac-hacks.org/wiki/PeerReviewPlugin>` Could be integrated with the current ticket system?, not maintained, review code in general, not commit.
-- `feature request at assembla <http://feedback.assembla.com/forums/5433-feature-requests/suggestions/253297-add-a-code-review-tool-e-g-reviewboard->`
-- `JCR <http://jcodereview.sourceforge.net/>`
+- `rietveld <http://code.google.com/p/rietveld/>`_
+    - Made by Guido van Rossum, seam basic and svn only
+    - No, not enough features
+
+- `Gerrit <http://code.google.com/p/gerrit/>`_
+    - git only
+    - No
+
+- `Review Board <http://www.reviewboard.org>`_
+    - Interesting, but some questions remain (how well it integrates with hg,
+      notably)
+    - Some advantages over Google code (comment on multi-line chunks, list of
+      unreviewed commits)
+    - Fred will install it so we can test it more thoroughly
+
+- `Code Striker <http://codestriker.sourceforge.net/>`_
+    - hg added? David told in May 2009 it can do it easily.
+    - Seems less interesting than Review Board
+    - No
+
+- `Code Review plugins in Redmine <http://www.redmine.org/boards/3/topics/9627>`_
+    - No
+
+- `track PeerReviewPlugin <http://trac-hacks.org/wiki/PeerReviewPlugin>`_
+    - Could be integrated with the current ticket system?, not maintained, review code in general, not commit.
+    - No
+
+- `feature request at assembla <http://feedback.assembla.com/forums/5433-feature-requests/suggestions/253297-add-a-code-review-tool-e-g-reviewboard->`_
+    - No (we will not wait until the feature is added...)
+
+- `JCR <http://jcodereview.sourceforge.net/>`_
+    - No
+
+- `Google Code <http://code.google.com/>`_
+    - Test bench with a clone of Theano at
+      http://code.google.com/p/theanoclone/
+    - Maybe
 
 What we could want from our code review
 ---------------------------------------