# HG changeset patch # User Pascal Lamblin # Date 1285705641 14400 # Node ID 10113a1050ce24c25e18fcbe4ae16c9333100c11 # Parent 4d7fdd04b66a4ee0e4f15c29de30b1d422ae9641 More RST diff -r 4d7fdd04b66a -r 10113a1050ce doc/v2_planning/code_review.txt --- a/doc/v2_planning/code_review.txt Tue Sep 28 14:02:29 2010 -0400 +++ b/doc/v2_planning/code_review.txt Tue Sep 28 16:27:21 2010 -0400 @@ -18,14 +18,43 @@ Some system that we should check: --------------------------------- -- `rietveld ` Made by Guido van Rossum, seam basic and svn only -- `Gerrit `, git only -- *`Review Board `_ -- *`Code Striker `, hg added? David told in May 2009 it can do it easily. -- *`Code Review plugins in Redmine ` -- `track PeerReviewPlugin ` Could be integrated with the current ticket system?, not maintained, review code in general, not commit. -- `feature request at assembla ` -- `JCR ` +- `rietveld `_ + - Made by Guido van Rossum, seam basic and svn only + - No, not enough features + +- `Gerrit `_ + - git only + - No + +- `Review Board `_ + - Interesting, but some questions remain (how well it integrates with hg, + notably) + - Some advantages over Google code (comment on multi-line chunks, list of + unreviewed commits) + - Fred will install it so we can test it more thoroughly + +- `Code Striker `_ + - hg added? David told in May 2009 it can do it easily. + - Seems less interesting than Review Board + - No + +- `Code Review plugins in Redmine `_ + - No + +- `track PeerReviewPlugin `_ + - Could be integrated with the current ticket system?, not maintained, review code in general, not commit. + - No + +- `feature request at assembla `_ + - No (we will not wait until the feature is added...) + +- `JCR `_ + - No + +- `Google Code `_ + - Test bench with a clone of Theano at + http://code.google.com/p/theanoclone/ + - Maybe What we could want from our code review ---------------------------------------