Mercurial > MadButterfly

changeset 1415:f34d2fcbcd0d

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Revert changeset #88c8c874f4b8. #88c8c874f4b8 try to fix crashing, but it blame to wrong code. If you look into runtime stack of xnjsmb_coord_remove(), you will find self argument is already wrong. It is in an invalid address.
author Thinker K.F. Li <thinker@codemud.net>
date Wed, 06 Apr 2011 15:13:09 +0800
parents 036f2b447860
children c60a978f98b1
files nodejs/coord.cc
diffstat 1 files changed, 0 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/nodejs/coord.cc	Wed Apr 06 14:37:34 2011 +0800
+++ b/nodejs/coord.cc	Wed Apr 06 15:13:09 2011 +0800
@@ -81,7 +81,6 @@
     FOR_COORDS_PREORDER(coord, child) {
 	child_hdl = (Persistent<Object> *)mb_prop_get(&child->obj.props,
 						      PROP_JSOBJ);
-	if (child_hdl == NULL) continue;
 	SET(*child_hdl, "valid", _false);
 	WRAP(*child_hdl, NULL);
 	child_hdl->Dispose();
@@ -91,7 +90,6 @@
 	FOR_COORD_SHAPES(child, mem) {
 	    mem_hdl = (Persistent<Object> *)mb_prop_get(&mem->obj.props,
 							PROP_JSOBJ);
-	    if (mem_hdl == NULL) continue;							
 	    SET(*mem_hdl, "valid", _false);
 	    WRAP(*mem_hdl, NULL);
 	    mem_hdl->Dispose();