almixer_isolated: ALmixer.c comparison

comparison ALmixer.c @ 74:c112e4576832

Fixed remaining fading bug for pause/resume. My technique was wrong. I computed the amount of time remaining on pause and when I resumed, I grabbed the current time as the start and used the time remaining as the end. I think this is wrong because the volume curve may not be linear if I do this. Instead, I will try saving the time remaining, but preserve the original fade duration. Then I will adjust the start time for the amount already played. So I don't need to create another variable, I will overwrite the fade start.

author	Eric Wing <ewing . public \|-at-\| gmail . com>
date	Fri, 10 Aug 2012 23:38:56 -0700
parents	32757e494675
children	609d597b0dd9

comparison

equal deleted inserted replaced

-:32757e494675
+:c112e4576832
 				}
 				/* Do the same as expire time for fading */
 				if(ALmixer_Channel_List[channel].fade_enabled)
 				{
 					ALuint current_time = ALmixer_GetTicks();
-					ALuint diff_time;
+					ALuint used_up_time;
-					diff_time = current_time -
+					used_up_time = current_time -
 						ALmixer_Channel_List[channel].fade_start_time;
 					/* When we unpause, we will want to reset
 					 * the start time so we can continue
 					 * to base calculations off GetTicks().
-					 * This means we need to subtract the amount
+					 * I originally did this wrong. I computed the amount of time remaining
-					 * of time already used up from expire_ticks.
+					 * and when I resumed, I grabbed the current time as the start and used the time remaining as the end.
+					 * I think this is wrong because the volume curve may not be linear.
+					 * Instead, I will try saving the time remaining, but preserve the original fade duration.
+					 * Then I will adjust the start time for the amount already played.
+					 * So I don't need to create another variable, I will overwrite the start time with the remaining time.
+					 * (Resume needs to know this implementation detail.)
 					 */
-					ALmixer_Channel_List[channel].fade_expire_ticks =
+					ALmixer_Channel_List[channel].fade_start_time = used_up_time;
-						ALmixer_Channel_List[channel].fade_expire_ticks -
-						diff_time;
-					/* Don't allow the time to go negative */
-					if(ALmixer_Channel_List[channel].fade_expire_ticks < 0)
-					{
-						ALmixer_Channel_List[channel].fade_expire_ticks = 0;
-					}
 				} /* End fade check */
 			} /* End if PLAYING */
 		} /* End If in use */
 	} /* End specific channel */
 	/* The user wants to halt all channels */
 					}
 					/* Do the same as expire time for fading */
 					if(ALmixer_Channel_List[i].fade_enabled)
 					{
 						ALuint current_time = ALmixer_GetTicks();
-						ALuint diff_time;
+						ALuint used_up_time;
-						diff_time = current_time -
+						used_up_time = current_time -
-							ALmixer_Channel_List[i].fade_start_time;
+								ALmixer_Channel_List[i].fade_start_time;
 						/* When we unpause, we will want to reset
 						 * the start time so we can continue
 						 * to base calculations off GetTicks().
-						 * This means we need to subtract the amount
+						 * I originally did this wrong. I computed the amount of time remaining
-						 * of time already used up from expire_ticks.
+						 * and when I resumed, I grabbed the current time as the start and used the time remaining as the end.
+						 * I think this is wrong because the volume curve may not be linear.
+						 * Instead, I will try saving the time remaining, but preserve the original fade duration.
+						 * Then I will adjust the start time for the amount already played.
+						 * So I don't need to create another variable, I will overwrite the start time with the remaining time.
+						 * (Resume needs to know this implementation detail.)
 						 */
-						ALmixer_Channel_List[i].fade_expire_ticks =
+						ALmixer_Channel_List[i].fade_start_time = used_up_time;
-							ALmixer_Channel_List[i].fade_expire_ticks -
-							diff_time;
-						/* Don't allow the time to go negative */
-						if(ALmixer_Channel_List[i].fade_expire_ticks < 0)
-						{
-							ALmixer_Channel_List[i].fade_expire_ticks = 0;
-						}
 					} /* End fade check */
 				} /* End if PLAYING */
 			} /* End channel in use */
 		} /* End for-loop */
 	}
 					ALmixer_Channel_List[channel].start_time = ALmixer_GetTicks();
 				}
 				/* Do the same as expire time for fading */
 				if(ALmixer_Channel_List[channel].fade_enabled)
 				{
-					ALmixer_Channel_List[channel].fade_start_time = ALmixer_GetTicks();
+					/* I originally did this wrong. On pause, I computed the amount of time remaining
-				}
+					 * and when I resumed, I grabbed the current time as the start and used the time remaining as the end.
+					 * I think this is wrong because the volume curve may not be linear.
+					 * Instead, I will try saving the time remaining, but preserve the original fade duration.
+					 * Then I will adjust the start time for the amount already played.
+					 * So I don't need to create another variable, I will overwrite the start time with the remaining time
+					 * (Resume needs to know this implementation detail.)
+					 */
+					ALuint current_time = ALmixer_GetTicks();
+					/* Recover the used_up_time from the overloaded fade_start_time variable */
+					ALuint used_up_time = ALmixer_Channel_List[channel].fade_start_time;
+					/* So the adjusted start time is: */
+					ALmixer_Channel_List[channel].fade_start_time = current_time - used_up_time;
+				}
 				alSourcePlay(ALmixer_Channel_List[channel].alsource);
 				if((error = alGetError()) != AL_NO_ERROR)
 				{
 					ALmixer_SetError("%s",
 						ALmixer_Channel_List[i].start_time = ALmixer_GetTicks();
 					}
 					/* Do the same as expire time for fading */
 					if(ALmixer_Channel_List[i].fade_enabled)
 					{
-						ALmixer_Channel_List[i].fade_start_time = ALmixer_GetTicks();
+						/* I originally did this wrong. On pause, I computed the amount of time remaining
+						 * and when I resumed, I grabbed the current time as the start and used the time remaining as the end.
+						 * I think this is wrong because the volume curve may not be linear.
+						 * Instead, I will try saving the time remaining, but preserve the original fade duration.
+						 * Then I will adjust the start time for the amount already played.
+						 * So I don't need to create another variable, I will overwrite the start time with the remaining time
+						 * (Resume needs to know this implementation detail.)
+						 */
+						ALuint current_time = ALmixer_GetTicks();
+						/* Recover the used_up_time from the overloaded fade_start_time variable */
+						ALuint used_up_time = ALmixer_Channel_List[i].fade_start_time;
+						/* So the adjusted start time is: */
+						ALmixer_Channel_List[i].fade_start_time = current_time - used_up_time;
 					}
 					alSourcePlay(ALmixer_Channel_List[i].alsource);
 					if((error = alGetError()) != AL_NO_ERROR)
 					{

Mercurial > almixer_isolated

comparison ALmixer.c @ 74:c112e4576832