# HG changeset patch # User Sam Lantinga # Date 1064169651 0 # Node ID ab0656314eeff92b2dc7210e741ac0dc7c0c2c49 # Parent f90d80d68071146b0309758c0ebd463aae540c68 Date: Thu, 18 Sep 2003 14:24:35 -0400 From: Scott Watson Subject: [SDL] Improper Windows message routine calling If this hasn't been caught yet, there's an improper method of calling a user's window message routine in the various SDL_xxevents.c files. Calling it improperly can cause a crash under at least XP. diff -r f90d80d68071 -r ab0656314eef src/video/windib/SDL_dibevents.c --- a/src/video/windib/SDL_dibevents.c Sun Sep 21 18:32:04 2003 +0000 +++ b/src/video/windib/SDL_dibevents.c Sun Sep 21 18:40:51 2003 +0000 @@ -177,7 +177,7 @@ along to any win32 specific window proc. */ } else if (userWindowProc) { - return userWindowProc(hwnd, msg, wParam, lParam); + return CallWindowProc(userWindowProc, hwnd, msg, wParam, lParam); } } break; diff -r f90d80d68071 -r ab0656314eef src/video/windx5/SDL_dx5events.c --- a/src/video/windx5/SDL_dx5events.c Sun Sep 21 18:32:04 2003 +0000 +++ b/src/video/windx5/SDL_dx5events.c Sun Sep 21 18:40:51 2003 +0000 @@ -537,13 +537,13 @@ wmmsg.lParam = lParam; posted = SDL_PrivateSysWMEvent(&wmmsg); - /* DJM: If the user isn't watching for private messages in her - SDL event loop, then pass it along to any win32 specific - window proc. - */ - } else if (userWindowProc) { - return userWindowProc(hwnd, msg, wParam, lParam); - } + /* DJM: If the user isn't watching for private + messages in her SDL event loop, then pass it + along to any win32 specific window proc. + */ + } else if (userWindowProc) { + return CallWindowProc(userWindowProc, hwnd, msg, wParam, lParam); + } } break; }