# HG changeset patch # User Patrice Mandin # Date 1137706132 0 # Node ID 448a9a64537b9ef87c7965e93bb232416cb3e6de # Parent 3cfb04f6e7269832e36f3878f40e7ac1f6c4c79e [PATCH] SDL_GetVideoMode() does not find best mode, part 2 Following commit 1.51, I come accross a problem when SDL must choose between several video modes that could suit the one asked. If I ask 320x240 with this list: 768x480 768x240 640x400 640x200 384x480 384x240 320x400 320x200 The smallest selectables modes are 384x240 and 320x400. And SDL choose the later in this list, but 384x240 is more suitable. So I added a check to compare the pixel count (surface) of modes, and select the one which has the smallest pixel count. In my example, 384x240 has 92160 pixels, and 320x400 has 128000 pixels. So now SDL will choose 384x240 for the asked 320x240 mode. diff -r 3cfb04f6e726 -r 448a9a64537b src/video/SDL_video.c --- a/src/video/SDL_video.c Thu Jan 19 18:08:28 2006 +0000 +++ b/src/video/SDL_video.c Thu Jan 19 21:28:52 2006 +0000 @@ -488,8 +488,11 @@ if ((sizes[i]->w >= *w) && (sizes[i]->h >= *h)) { /* Mode with any dimension smaller or equal than current best ? */ if ((sizes[i]->w <= sizes[best]->w) || (sizes[i]->h <= sizes[best]->h)) { - best=i; - supported = 1; + /* Now choose the mode that has less pixels */ + if ((sizes[i]->w * sizes[i]->h) < (sizes[best]->w * sizes[best]->h)) { + best=i; + supported = 1; + } } } }