Mercurial > sdl-ios-xcode
view TODO @ 1543:98f9b16f565c
From: "Alex Volkov"
Date: Thu, 10 Nov 2005 21:53:40 -0500
Subject: [SDL] BUG[?]: 32bpp RGBA->RGB colorkey blit, no SDL_SRCALPHA
It seems there is either a documentation vs. reality mismatch or a real bug
in SDL_blit_N.c:BlitNtoNKey().
The exact blit in question is a 32bpp RGBA->RGB, where RGBA has SDL_COLORKEY
and *no* SDL_SRCALPHA flags. The doc in SDL_video.h states:
* RGBA->RGB:
* SDL_SRCALPHA not set:
* copy RGB.
* if SDL_SRCCOLORKEY set, only copy the pixels matching the
* RGB values of the source colour key, ignoring alpha in the
* comparison.
BlitNtoNKey(), however, forgets to "ignore alpha in the comparison". The
documentation makes perfect sense, so I think it is the code that is faulty.
The attached patch corrects the code.
| author | Sam Lantinga <slouken@libsdl.org> |
|---|---|
| date | Wed, 15 Mar 2006 15:43:15 +0000 |
| parents | f02e673ffc5f |
| children | f12379c41042 |
line wrap: on
line source
Wish list for the 1.3 development branch: http://bugzilla.libsdl.org/ * Add mousewheel events (new unified event architecture?) * DirectInput joystick support needs to be implemented * Be able to enumerate and select available audio and video drivers * Fullscreen video mode support for MacOS X * Explicit vertical retrace wait (maybe separate from SDL_Flip?) * Shaped windows, windows without borders * Multiple windows, multiple display support * SDL_INIT_EVENTTHREAD on Windows and MacOS? * Add a timestamp to events * Add audio input API * Add hardware accelerated scaled blit * Add hardware accelerated alpha blits * Redesign blitting architecture to allow blit plugins In the jump from 1.2 to 1.3, we should change the SDL_Rect members to int and evaluate all the rest of the datatypes. This is the only place we should do it though, since the 1.2 series should not break binary compatibility in this way. Requests: * PCM and CDROM volume control (deprecated, but possible)