Mercurial > sdl-ios-xcode
view docs/man3/SDL_WasInit.3 @ 1748:5e86e34453d4
------- Comment #1 From Max Horn 2006-04-17 03:08 [reply] -------
Created an attachment (id=106) [edit]
Patch for src/joystick/win32/SDL_mmjoystick.c
I am not even a Windows user, so take the following with a grain of salt:
SDL_mmjoystick.c has a function GetJoystickName which obtains the joystick
name by looking at the registry. The way it does that seems very fishy to me.
Namely, it uses the parameter "index" to construct a registry value name (BTW,
those variables used in the code are really badly named). The value of "index"
in turn equals the current value of "numdevs", as called from
SDL_SYS_JoystickInit.
I read through the MSDN docs at
<http://msdn.microsoft.com/archive/default.asp?url=/archive/en-us/dnarinput/html/msdn_extdirect.asp>,
and I believe the simple fix is to replace line 183 of said file
SYS_JoystickName[numdevs] = GetJoystickName(numdevs, joycaps.szRegKey);
by the following:
SYS_JoystickName[numdevs] = GetJoystickName(SYS_JoystickID[i],
joycaps.szRegKey);
However, that is only *hiding* the real issue. Problem is, the list of
joysticks as returned by windows may contains "gaps", and the code deals
incorrectly with that. Namely those gaps occur if joysticks are
removed/(re)added, as the reporter observed.
The attached patch fixes this and another (off-by-one) issue in the code. But
since I have no Windows machine, I can't even test-compile it, so use with
caution.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Sat, 29 Apr 2006 20:22:31 +0000 |
parents | e5bc29de3f0a |
children | 546f7c1eb755 |
line wrap: on
line source
.TH "SDL_WasInit" "3" "Tue 11 Sep 2001, 23:00" "SDL" "SDL API Reference" .SH "NAME" SDL_WasInit\- Check which subsystems are initialized .SH "SYNOPSIS" .PP \fB#include "SDL\&.h" .sp \fBUint32 \fBSDL_WasInit\fP\fR(\fBUint32 flags\fR); .SH "DESCRIPTION" .PP \fBSDL_WasInit\fP allows you to see which SDL subsytems have been \fIinitialized\fR\&. \fBflags\fR is a bitwise OR\&'d combination of the subsystems you wish to check (see \fI\fBSDL_Init\fP\fR for a list of subsystem flags)\&. .SH "RETURN VALUE" .PP \fBSDL_WasInit\fP returns a bitwised OR\&'d combination of the initialized subsystems\&. .SH "EXAMPLES" .PP .nf \f(CW /* Here are several ways you can use SDL_WasInit() */ /* Get init data on all the subsystems */ Uint32 subsystem_init; subsystem_init=SDL_WasInit(SDL_INIT_EVERYTHING); if(subsystem_init&SDL_INIT_VIDEO) printf("Video is initialized\&. "); else printf("Video is not initialized\&. "); /* Just check for one specfic subsystem */ if(SDL_WasInit(SDL_INIT_VIDEO)!=0) printf("Video is initialized\&. "); else printf("Video is not initialized\&. "); /* Check for two subsystems */ Uint32 subsystem_mask=SDL_INIT_VIDEO|SDL_INIT_AUDIO; if(SDL_WasInit(subsystem_mask)==subsystem_mask) printf("Video and Audio initialized\&. "); else printf("Video and Audio not initialized\&. "); \fR .fi .PP .SH "SEE ALSO" .PP \fI\fBSDL_Init\fP\fR, \fI\fBSDL_Subsystem\fP\fR ...\" created by instant / docbook-to-man, Tue 11 Sep 2001, 23:00