Mercurial > sdl-ios-xcode
view docs/man3/SDL_GLattr.3 @ 1748:5e86e34453d4
------- Comment #1 From Max Horn 2006-04-17 03:08 [reply] -------
Created an attachment (id=106) [edit]
Patch for src/joystick/win32/SDL_mmjoystick.c
I am not even a Windows user, so take the following with a grain of salt:
SDL_mmjoystick.c has a function GetJoystickName which obtains the joystick
name by looking at the registry. The way it does that seems very fishy to me.
Namely, it uses the parameter "index" to construct a registry value name (BTW,
those variables used in the code are really badly named). The value of "index"
in turn equals the current value of "numdevs", as called from
SDL_SYS_JoystickInit.
I read through the MSDN docs at
<http://msdn.microsoft.com/archive/default.asp?url=/archive/en-us/dnarinput/html/msdn_extdirect.asp>,
and I believe the simple fix is to replace line 183 of said file
SYS_JoystickName[numdevs] = GetJoystickName(numdevs, joycaps.szRegKey);
by the following:
SYS_JoystickName[numdevs] = GetJoystickName(SYS_JoystickID[i],
joycaps.szRegKey);
However, that is only *hiding* the real issue. Problem is, the list of
joysticks as returned by windows may contains "gaps", and the code deals
incorrectly with that. Namely those gaps occur if joysticks are
removed/(re)added, as the reporter observed.
The attached patch fixes this and another (off-by-one) issue in the code. But
since I have no Windows machine, I can't even test-compile it, so use with
caution.
| author | Sam Lantinga <slouken@libsdl.org> |
|---|---|
| date | Sat, 29 Apr 2006 20:22:31 +0000 |
| parents | e5bc29de3f0a |
| children | 546f7c1eb755 |
line wrap: on
line source
.TH "SDL_GLattr" "3" "Tue 11 Sep 2001, 23:01" "SDL" "SDL API Reference" .SH "NAME" SDL_GLattr\- SDL GL Attributes .SH "ATTRIBUTES" .TP 20 \fBSDL_GL_RED_SIZE\fP Size of the framebuffer red component, in bits .TP 20 \fBSDL_GL_GREEN_SIZE\fP Size of the framebuffer green component, in bits .TP 20 \fBSDL_GL_BLUE_SIZE\fP Size of the framebuffer blue component, in bits .TP 20 \fBSDL_GL_ALPHA_SIZE\fP Size of the framebuffer alpha component, in bits .TP 20 \fBSDL_GL_DOUBLEBUFFER\fP 0 or 1, enable or disable double buffering .TP 20 \fBSDL_GL_BUFFER_SIZE\fP Size of the framebuffer, in bits .TP 20 \fBSDL_GL_DEPTH_SIZE\fP Size of the depth buffer, in bits .TP 20 \fBSDL_GL_STENCIL_SIZE\fP Size of the stencil buffer, in bits .TP 20 \fBSDL_GL_ACCUM_RED_SIZE\fP Size of the accumulation buffer red component, in bits .TP 20 \fBSDL_GL_ACCUM_GREEN_SIZE\fP Size of the accumulation buffer green component, in bits .TP 20 \fBSDL_GL_ACCUM_BLUE_SIZE\fP Size of the accumulation buffer blue component, in bits .TP 20 \fBSDL_GL_ACCUM_ALPHA_SIZE\fP Size of the accumulation buffer alpha component, in bits .SH "DESCRIPTION" .PP While you can set most OpenGL attributes normally, the attributes list above must be known \fIbefore\fP SDL sets the video mode\&. These attributes a set and read with \fI\fBSDL_GL_SetAttribute\fP\fR and \fI\fBSDL_GL_GetAttribute\fP\fR\&. .SH "SEE ALSO" .PP \fI\fBSDL_GL_SetAttribute\fP\fR, \fI\fBSDL_GL_GetAttribute\fP\fR ...\" created by instant / docbook-to-man, Tue 11 Sep 2001, 23:01