Mercurial > sdl-ios-xcode
view src/video/ataricommon/SDL_xbiosinterrupt.S @ 1287:15a89a0c52bf
Date: Tue, 15 Feb 2005 21:28:48 +0900 (JST)
From: "Michael Leonhard"
Subject: [SDL] resize bug on Win32 and patch
This is my first post to this mailing list. In this email I will detail a
bug in the behavior of resizable SDL windows on Win32. Then I will
explain the solution and provide a patch.
Symptoms:
Under Windows, an SDL display created with the SDL_RESIZABLE flag exhibits
quirky behavior when being maximized. The window is resized to the proper
size, but it is shifted upwards about half the height of the title bar.
Similarly, a window whose origin is above the top of the screen will
spontaneously move its upper-left origin upon being resized. After two
such resize-induced moves, the title bar will be entirely off the top edge
of the screen. Subsequently, when the mouse is clicked and released on
the window border, the window will shrink its height spontaneously. This
height shrinkage occurs even if the user did not resize the border.
To observe this curious situation, please invoke:
SDL-1.2.8/test/testwm.exe -resize
Cause:
A pair of integers, SDL_windowX and SDL_windowY, are defined in
video/wincommon/SDL_sysevents.c. They are used by the DirectX video
driver and the DIB video driver:
video/windx5/SDL_dx5video.c
video/windib/SDL_dibvideo.c
As I understand the source code, the primary use of these variables is to
create a rectangle that represents the surface area in CLIENT SPACE.
Client space refers to a coordinate system that originates at the upper
left corner of a Win32 Window's drawable area. This is just inside the
window border and title bar. This client space rectangle, called bounds,
is subsequently converted to screen space with a call to
AdjustWindowRectEx. The problem is found in SDL's handling of the
WM_WINDOWPOSCHANGED message. According to MSDN,
"The WM_WINDOWPOSCHANGED message is sent to a window whose
size, position, or place in the Z order has changed as a
result of a call to the SetWindowPos function or another
window-management function."
I have confirmed that this message is indeed being sent to the SDL window
when the mouse is clicked on the window border, even if the window border
is not dragged.
In video/wincommon/SDL_sysevents.c, on line 464, in response to the
WM_WINDOWPOSCHANGED message, the (potentially) new client rectangle is
obtained. This rectangle is translated into screen coordinates and THEN
assigned to the SDL_windowX and Y variables. Thus screen coordinates are
being assigned to client coordinate variables. Once this is understood,
the solution is apparent: assign SDL_windowX and Y before translating the
rectangle to screen coordinates. This is accomplished by the following
patch.
-Mike_L
| author | Sam Lantinga <slouken@libsdl.org> |
|---|---|
| date | Sun, 29 Jan 2006 08:50:06 +0000 |
| parents | 0fb50bfaea7f |
| children | c9b51268668f |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997, 1998, 1999, 2000, 2001, 2002 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; if not, write to the Free Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Sam Lantinga slouken@libsdl.org */ #ifdef SAVE_RCSID static char rcsid = "@(#) $Id$"; #endif /* * XBIOS mouse & joystick vectors * * Patrice Mandin */ .text .globl _SDL_AtariXbios_Install .globl _SDL_AtariXbios_Restore .globl _SDL_AtariXbios_MouseVector .globl _SDL_AtariXbios_JoystickVector .globl _SDL_AtariXbios_mouseb .globl _SDL_AtariXbios_mousex .globl _SDL_AtariXbios_mousey .globl _SDL_AtariXbios_joystick /*--- Vector installer ---*/ _SDL_AtariXbios_Install: movel sp@(4),a0 /* Stop interrupts */ movew #0x2700,sr /* Save old mouse vector, set our routine */ clrl oldmousevector movel sp@(8),d0 beqs no_new_mouse_vector movel a0@(16),oldmousevector movel d0,a0@(16) no_new_mouse_vector: /* Save old joystick vector, set our routine */ clrl oldjoystickvector movel sp@(12),d0 beqs no_new_joystick_vector movel a0@(24),oldjoystickvector movel d0,a0@(24) no_new_joystick_vector: /* Restart interrupts */ movew #0x2300,sr rts /*--- Vector restorer ---*/ _SDL_AtariXbios_Restore: movel sp@(4),a0 /* Stop interrupts */ movew #0x2700,sr /* Restore mouse vector */ movel oldmousevector,d0 beqs no_restore_mouse movel d0,a0@(16) no_restore_mouse: /* Restore joystick vector */ movel oldjoystickvector,d0 beqs no_restore_joystick movel d0,a0@(24) no_restore_joystick: /* Restart interrupts */ movew #0x2300,sr rts /*--- Our mouse vector ---*/ .text .even .ascii "XBRA" .ascii "LSDL" .comm oldmousevector,4*1 _SDL_AtariXbios_MouseVector: movel d0,sp@- /* Mouse buttons */ moveb (a0),d0 andw #3,d0 movew d0,_SDL_AtariXbios_mouseb /* X movement */ moveb a0@(1),d0 extw d0 addw d0,_SDL_AtariXbios_mousex /* Y movement */ moveb a0@(2),d0 extw d0 addw d0,_SDL_AtariXbios_mousey /* Jump through old vector */ movel sp@+,d0 movel oldmousevector,sp@- rts .data .even .comm _SDL_AtariXbios_mousex,2*1 .even .comm _SDL_AtariXbios_mousey,2*1 .even .comm _SDL_AtariXbios_mouseb,2*1 /*--- Our joystick vector ---*/ .text .even .ascii "XBRA" .ascii "LSDL" .comm oldjoystickvector,4*1 _SDL_AtariXbios_JoystickVector: movel d0,sp@- /* New joystick state */ moveb a0@(2),d0 andw #0x8f,d0 movew d0,_SDL_AtariXbios_joystick /* Jump through old vector */ movel sp@+,d0 movel oldjoystickvector,sp@- rts .data .even .comm _SDL_AtariXbios_joystick,2*1