Mercurial > sdl-ios-xcode
annotate TODO @ 1543:98f9b16f565c
From: "Alex Volkov"
Date: Thu, 10 Nov 2005 21:53:40 -0500
Subject: [SDL] BUG[?]: 32bpp RGBA->RGB colorkey blit, no SDL_SRCALPHA
It seems there is either a documentation vs. reality mismatch or a real bug
in SDL_blit_N.c:BlitNtoNKey().
The exact blit in question is a 32bpp RGBA->RGB, where RGBA has SDL_COLORKEY
and *no* SDL_SRCALPHA flags. The doc in SDL_video.h states:
* RGBA->RGB:
* SDL_SRCALPHA not set:
* copy RGB.
* if SDL_SRCCOLORKEY set, only copy the pixels matching the
* RGB values of the source colour key, ignoring alpha in the
* comparison.
BlitNtoNKey(), however, forgets to "ignore alpha in the comparison". The
documentation makes perfect sense, so I think it is the code that is faulty.
The attached patch corrects the code.
| author | Sam Lantinga <slouken@libsdl.org> |
|---|---|
| date | Wed, 15 Mar 2006 15:43:15 +0000 |
| parents | f02e673ffc5f |
| children | f12379c41042 |
| rev | line source |
|---|---|
| 0 | 1 |
| 2 Wish list for the 1.3 development branch: | |
|
1534
f02e673ffc5f
*** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents:
1441
diff
changeset
|
3 http://bugzilla.libsdl.org/ |
| 0 | 4 |
| 5 * Add mousewheel events (new unified event architecture?) | |
| 6 * DirectInput joystick support needs to be implemented | |
| 7 * Be able to enumerate and select available audio and video drivers | |
| 8 * Fullscreen video mode support for MacOS X | |
| 9 * Explicit vertical retrace wait (maybe separate from SDL_Flip?) | |
| 10 * Shaped windows, windows without borders | |
| 11 * Multiple windows, multiple display support | |
| 12 * SDL_INIT_EVENTTHREAD on Windows and MacOS? | |
| 13 * Add a timestamp to events | |
| 14 * Add audio input API | |
|
2
836aaee3f39e
*** empty log message ***
Sam Lantinga <slouken@lokigames.com>
parents:
0
diff
changeset
|
15 * Add hardware accelerated scaled blit |
|
836aaee3f39e
*** empty log message ***
Sam Lantinga <slouken@lokigames.com>
parents:
0
diff
changeset
|
16 * Add hardware accelerated alpha blits |
|
836aaee3f39e
*** empty log message ***
Sam Lantinga <slouken@lokigames.com>
parents:
0
diff
changeset
|
17 * Redesign blitting architecture to allow blit plugins |
| 0 | 18 |
| 19 In the jump from 1.2 to 1.3, we should change the SDL_Rect members to | |
| 20 int and evaluate all the rest of the datatypes. This is the only place | |
| 21 we should do it though, since the 1.2 series should not break binary | |
| 22 compatibility in this way. | |
| 150 | 23 |
| 24 Requests: | |
| 25 * PCM and CDROM volume control (deprecated, but possible) |