# HG changeset patch
# User Frederic Bastien <nouiz@nouiz.org>
# Date 1286375994 14400
# Node ID 431d0db694998e7d886165c4c15c7f06fa96ac73
# Parent  f5e9c00a67d78e484bab2dce5e1306ad54770d98
added info about the commit message.

diff -r f5e9c00a67d7 -r 431d0db69499 doc/v2_planning/coding_style.txt
--- a/doc/v2_planning/coding_style.txt	Tue Oct 05 12:31:36 2010 -0400
+++ b/doc/v2_planning/coding_style.txt	Wed Oct 06 10:39:54 2010 -0400
@@ -390,7 +390,30 @@
     - The fetch commit message is like "Automated merge with
       https://theanoclone.googlecode.com/hg/". It is too long to ask people to
       use the same. I guess "Merge" would be the most logical message to use.
-      
+
+FB: The proposed guide line
+    * A one line summary
+    * If needed a blanc line followed by a more detailed summary
+    * Make a commit for each logical modification
+        * This make review easier to do
+        * This make debugging easier as we can more easily pinpint error in commit with hg bisect
+    * NEVER commit reformating change with functionality
+    * HG RECORD/DIFF are your friend
+        * hg record allow you to record select the change to a file to commit
+        * hg record force you to review your code!
+    * Review your code before commit
+    * Stuff from django guide
+        * Write detailed commit messages in the past tense, not present tense.
+            * Good: "Fixed Unicode bug in RSS API."
+            * Bad: "Fixes Unicode bug in RSS API."
+            * Bad: "Fixing Unicode bug in RSS API."
+        * Separate bug fixes from feature changes.
+        * ? If fix a ticket, make the message start with "Fixed #abc"
+            * Can make a system to change the ticket?
+        * ? If reference a ticket, make the message start with "Refs #abc"
+            * Can make a system to put a comment to the ticket?
+
+
 Tools to help us out
 ---------------------