view doc/v2_planning/code_review.txt @ 1241:6801451a86bb

Add a point I brought during the last architecture meeting.
author Pascal Lamblin <lamblinp@iro.umontreal.ca>
date Thu, 23 Sep 2010 12:02:58 -0400
parents a9b601119197
children 14444845989a
line wrap: on
line source


Code Review
===========

commity members
---------------

* Fred B.*, Pascal L., Olivier D., Arnaud B.

TODO
----

- make a list of point to compare tools
- review interresting projects
- make a decission

Some system that we should check:
---------------------------------

- `rietveld <http://code.google.com/p/rietveld/>` Made by Guido van Rossum
- `Gerrit <http://code.google.com/p/gerrit/>`
- `track PeerReviewPlugin <http://trac-hacks.org/wiki/PeerReviewPlugin>` Could be integrated with the current ticket system?
- `feature request at assembla <http://feedback.assembla.com/forums/5433-feature-requests/suggestions/253297-add-a-code-review-tool-e-g-reviewboard->`
- `Review Board <http://www.reviewboard.org>`_ 
- `reviewboard <http://code.google.com/p/reviewboard/>`
- `Code Striker <http://codestriker.sourceforge.net/>`
- `JCR <http://jcodereview.sourceforge.net/>`

What we could want from our code review
---------------------------------------

- integrate with our ticket system?
    - Should we keep our current ticket system?
- work with mercurial

Doc on code review
------------------

- http://code.google.com/p/support/wiki/CodeReviews
- http://ostatic.com/blog/open-source-code-review-tools
- http://en.wikipedia.org/wiki/Code_review

Alternative to code review
--------------------------

- Over-the-shoulder – One developer looks over the author's shoulder as the latter walks through the code.
- Email pass-around – Source code management system emails code to reviewers automatically after checkin is made.
- Pair Programming – Two authors develop code together at the same workstation, such is common in Extreme Programming.
- Tool-assisted code review – Authors and reviewers use specialized tools designed for peer code review.
- Test-Driven development