Mercurial > pylearn

diff doc/v2_planning/coding_style.txt @ 1138:9583e908c572

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
coding_style: Add a pylearn.compat module?
author Olivier Delalleau <delallea@iro>
date Thu, 16 Sep 2010 10:59:43 -0400
parents 5f0c8ff2b3b6
children 7d2e65249bf9
line wrap: on
line diff
--- a/doc/v2_planning/coding_style.txt	Thu Sep 16 09:26:31 2010 -0400
+++ b/doc/v2_planning/coding_style.txt	Thu Sep 16 10:59:43 2010 -0400
@@ -386,6 +386,8 @@
       in Python 2.4).
       You can use numpy.{all,any} instead of import theano.gof.python25 that 
       define all and any.
+      OD: I think we should have something like pylearn.compat.{all,any}.
+          numpy.{all,any} are meant to be used on arrays only.
 
     * Do not use the `hashlib` module (not supported in Python 2.4).
       You can do as in theano.gof.cc:
@@ -398,6 +400,8 @@
 	    import md5
 	    def hash_from_code(msg):
 	        return md5.new(msg).hexdigest()
+    OD: Yep, we could probably come up with such a wrapper in a pylearn.compat
+        module.
 
 Mercurial commits
 -----------------