Mercurial > pylearn
comparison doc/v2_planning/learner.txt @ 1045:d57bdd9a9980
learner: Left a comment about James' design
| author | Olivier Delalleau <delallea@iro> |
|---|---|
| date | Wed, 08 Sep 2010 13:43:57 -0400 |
| parents | 3b1fd599bafd |
| children | f1732269bce8 |
comparison
equal
deleted
inserted
replaced
| 1044:3b1fd599bafd | 1045:d57bdd9a9980 |
|---|---|
| 266 not good to say that the Learner instance *is* the node because (a) learner instances change | 266 not good to say that the Learner instance *is* the node because (a) learner instances change |
| 267 during graph exploration and (b) learner instances are big, and we don't want to have to keep a | 267 during graph exploration and (b) learner instances are big, and we don't want to have to keep a |
| 268 whole saved model just to attach meta-info e.g. validation score. Choosing this API spills | 268 whole saved model just to attach meta-info e.g. validation score. Choosing this API spills |
| 269 over into other committees, so we should get their feedback about how to resolve it. | 269 over into other committees, so we should get their feedback about how to resolve it. |
| 270 | 270 |
| 271 Comment by OD | |
| 272 ~~~~~~~~~~~~~ | |
| 273 (I hope it's ok to leave comments even though I'm not in committee... I'm | |
| 274 interested to see how the learner interface is shaping up so I'll be keeping | |
| 275 an eye on this file) | |
| 276 I'm wondering what's the benefit of such an API compared to simply defining a | |
| 277 new method for each instruction. It seems to me that typically, the 'execute' | |
| 278 method would end up being something like | |
| 279 if instruction == 'do_x': | |
| 280 self.do_x(..) | |
| 281 elif instruction == 'do_y': | |
| 282 self.do_y(..) | |
| 283 ... | |
| 284 so why not directly call do_x / do_y instead? | |
| 285 | |
| 271 Just another view/spin on the same idea (Razvan) | 286 Just another view/spin on the same idea (Razvan) |
| 272 ================================================ | 287 ================================================ |
| 273 | 288 |
| 274 | 289 |
| 275 My idea is probably just a spin off from what James wrote. It is an extension | 290 My idea is probably just a spin off from what James wrote. It is an extension |