Mercurial > pylearn

comparison doc/v2_planning/code_review.txt @ 1235:a9b601119197

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
added project to review and other stuff in code_review.txt
author Frederic Bastien <nouiz@nouiz.org>
date Thu, 23 Sep 2010 10:26:37 -0400
parents 91c285e30364
children 14444845989a
comparison
equal deleted inserted replaced
1234:3e264967d4e3 1235:a9b601119197
1 1
2 Code Review 2 Code Review
3 =========== 3 ===========
4 4
5 commity members
6 ---------------
7
8 * Fred B.*, Pascal L., Olivier D., Arnaud B.
9
10 TODO
11 ----
12
13 - make a list of point to compare tools
14 - review interresting projects
15 - make a decission
16
5 Some system that we should check: 17 Some system that we should check:
18 ---------------------------------
6 19
7 - `rietveld <http://code.google.com/p/rietveld/>` Made by Guido van Rossum 20 - `rietveld <http://code.google.com/p/rietveld/>` Made by Guido van Rossum
8 - `Gerrit <http://code.google.com/p/gerrit/>` 21 - `Gerrit <http://code.google.com/p/gerrit/>`
9 - `track PeerReviewPlugin <http://trac-hacks.org/wiki/PeerReviewPlugin>` Could be integrated with the current ticket system? 22 - `track PeerReviewPlugin <http://trac-hacks.org/wiki/PeerReviewPlugin>` Could be integrated with the current ticket system?
10 - `feature request at assembla <http://feedback.assembla.com/forums/5433-feature-requests/suggestions/253297-add-a-code-review-tool-e-g-reviewboard->` 23 - `feature request at assembla <http://feedback.assembla.com/forums/5433-feature-requests/suggestions/253297-add-a-code-review-tool-e-g-reviewboard->`
11 - `Review Board <http://www.reviewboard.org>`_ 24 - `Review Board <http://www.reviewboard.org>`_
25 - `reviewboard <http://code.google.com/p/reviewboard/>`
26 - `Code Striker <http://codestriker.sourceforge.net/>`
27 - `JCR <http://jcodereview.sourceforge.net/>`
12 28
13 What we could want from our code review: 29 What we could want from our code review
30 ---------------------------------------
14 31
15 - integrate with our ticket system? 32 - integrate with our ticket system?
16 - Should we keep our current ticket system? 33 - Should we keep our current ticket system?
34 - work with mercurial
35
36 Doc on code review
37 ------------------
38
39 - http://code.google.com/p/support/wiki/CodeReviews
40 - http://ostatic.com/blog/open-source-code-review-tools
41 - http://en.wikipedia.org/wiki/Code_review
42
43 Alternative to code review
44 --------------------------
45
46 - Over-the-shoulder – One developer looks over the author's shoulder as the latter walks through the code.
47 - Email pass-around – Source code management system emails code to reviewers automatically after checkin is made.
48 - Pair Programming – Two authors develop code together at the same workstation, such is common in Extreme Programming.
49 - Tool-assisted code review – Authors and reviewers use specialized tools designed for peer code review.
50 - Test-Driven development