Mercurial > SDL_sound_CoreAudio

changeset 351:069ce624d6cf

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
FIXME cleanup.
author Ryan C. Gordon <icculus@icculus.org>
date Thu, 06 Jun 2002 19:12:13 +0000
parents cafdbcae733d
children f0eb99670fa8
files decoders/mikmod.c decoders/mpglib.c decoders/quicktime.c decoders/shn.c decoders/smpeg.c decoders/wav.c
diffstat 6 files changed, 8 insertions(+), 9 deletions(-) [+]
line wrap: on
line diff
--- a/decoders/mikmod.c	Thu Jun 06 18:56:45 2002 +0000
+++ b/decoders/mikmod.c	Thu Jun 06 19:12:13 2002 +0000
@@ -311,7 +311,7 @@
     Player_SetPosition(ms);
     return(1);
 #else
-    BAIL_MACRO("!!! FIXME: Not implemented", 0);
+    BAIL_MACRO("MIKMOD: Seeking not implemented", 0);
 #endif
 } /* MIKMOD_seek */
 
--- a/decoders/mpglib.c	Thu Jun 06 18:56:45 2002 +0000
+++ b/decoders/mpglib.c	Thu Jun 06 19:12:13 2002 +0000
@@ -144,7 +144,7 @@
         if (mp3_magic[0] != 0xFF || (mp3_magic[1] & 0xF0) != 0xF0)
             BAIL_MACRO("MP3: Not an MP3 stream.", 0);
 
-            /* !!! FIXME: If the seek fails, we'll probably miss a frame */
+            /* If the seek fails, we'll probably miss a frame, but oh well. */
         SDL_RWseek(internal->rw, -sizeof (mp3_magic), SEEK_CUR);
     } /* if */
 
@@ -170,11 +170,10 @@
 
     SNDDBG(("MPGLIB: Accepting data stream.\n"));
 
-    /* !!! FIXME: Determine what format mpglib is spitting out... */
     internal->decoder_private = mpg;
     sample->actual.rate = mpglib_freqs[mpg->mp.fr.sampling_frequency];
     sample->actual.channels = mpg->mp.fr.stereo;
-    sample->actual.format = AUDIO_S16SYS; /* !!! FIXME: Is this right? */
+    sample->actual.format = AUDIO_S16SYS;
     sample->flags = SOUND_SAMPLEFLAG_NONE;
 
     return(1); /* we'll handle this data. */
@@ -290,7 +289,7 @@
 
 static int MPGLIB_seek(Sound_Sample *sample, Uint32 ms)
 {
-    BAIL_MACRO("!!! FIXME: Not implemented", 0);
+    BAIL_MACRO("MPGLIB: Seeking not implemented", 0);
 } /* MPGLIB_seek */
 
 #endif /* SOUND_SUPPORTS_MPGLIB */
--- a/decoders/quicktime.c	Thu Jun 06 18:56:45 2002 +0000
+++ b/decoders/quicktime.c	Thu Jun 06 19:12:13 2002 +0000
@@ -582,7 +582,7 @@
 
 static int QT_seek(Sound_Sample *sample, Uint32 ms)
 {
-    BAIL_MACRO("!!! FIXME: Not implemented", 0);
+    BAIL_MACRO("QUICKTIME: Seeking not implemented", 0);
 } /* QT_seek */
 
 
--- a/decoders/shn.c	Thu Jun 06 18:56:45 2002 +0000
+++ b/decoders/shn.c	Thu Jun 06 19:12:13 2002 +0000
@@ -1327,7 +1327,7 @@
 
 static int SHN_seek(Sound_Sample *sample, Uint32 ms)
 {
-    BAIL_MACRO("!!! FIXME: Not implemented", 0);
+    BAIL_MACRO("SHN: Seeking not implemented", 0);
 } /* SHN_seek */
 
 
--- a/decoders/smpeg.c	Thu Jun 06 18:56:45 2002 +0000
+++ b/decoders/smpeg.c	Thu Jun 06 19:12:13 2002 +0000
@@ -151,7 +151,7 @@
         if (mp3_magic[0] != 0xFF || (mp3_magic[1] & 0xF0) != 0xF0)
             BAIL_MACRO("MP3: Not an MP3 stream.", 0);
 
-            /* !!! FIXME: If the seek fails, we'll probably miss a frame */
+            /* If the seek fails, we'll probably miss a frame, but oh well */
         SDL_RWseek(internal->rw, -sizeof (mp3_magic), SEEK_CUR);
     } /* if */
 
--- a/decoders/wav.c	Thu Jun 06 18:56:45 2002 +0000
+++ b/decoders/wav.c	Thu Jun 06 19:12:13 2002 +0000
@@ -696,7 +696,7 @@
     sample->actual.channels = (Uint8) fmt->wChannels;
     sample->actual.rate = fmt->dwSamplesPerSec;
     if ((fmt->wBitsPerSample == 4) /*|| (fmt->wBitsPerSample == 0) */ )
-        sample->actual.format = AUDIO_S16SYS;  /* !!! FIXME ? */
+        sample->actual.format = AUDIO_S16SYS;
     else if (fmt->wBitsPerSample == 8)
         sample->actual.format = AUDIO_U8;
     else if (fmt->wBitsPerSample == 16)